Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ClearEmail to use a direct UPDATE query #7724

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Change ClearEmail to use a direct UPDATE query #7724

merged 3 commits into from
Sep 27, 2024

Conversation

jprenken
Copy link
Contributor

@jprenken jprenken commented Sep 25, 2024 •
edited by beautifulentropy
Loading

Change ClearEmail to use a direct UPDATE query instead of tx.Update(), in order to avoid LockCol issues.

Part of #7716

@jprenken jprenken requested a review from a team as a code owner September 25, 2024 22:50
@jprenken jprenken requested a review from jsha September 25, 2024 22:50
aarongable
aarongable reviewed Sep 25, 2024
View reviewed changes
sa/model.go Outdated Show resolved Hide resolved
sa/model.go Outdated Show resolved Hide resolved
aarongable
aarongable reviewed Sep 25, 2024
View reviewed changes
sa/model.go Outdated Show resolved Hide resolved
@jprenken jprenken merged commit 267c82d into main Sep 27, 2024
12 checks passed
@jprenken jprenken deleted the clearemail-update branch September 27, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsha jsha jsha approved these changes

@aarongable aarongable aarongable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jprenken @jsha @aarongable