fix: fix slice init length (#7731)

Initialize a slice with a capacity of len(nameToString) rather than initializing the length of this slice. Signed-off-by: huochexizhan <[email protected]>
letsencrypt · Oct 8, 2024 · a6dc97c · a6dc97c
1 parent 0a543d1
commit a6dc97c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ratelimits/limit_test.go b/ratelimits/limit_test.go
@@ -120,7 +120,7 @@ func TestLoadAndParseOverrideLimits(t *testing.T) {
 	// Burst cannot be 0.
 	_, err = loadAndParseOverrideLimits("testdata/busted_override_burst_0.yml")
 	test.AssertError(t, err, "single override limit with burst=0")
-	test.Assert(t, !os.IsNotExist(err), "test file should exist")
+	test.AssertContains(t, err.Error(), "invalid burst")
 
 	// Id cannot be empty.
 	_, err = loadAndParseOverrideLimits("testdata/busted_override_empty_id.yml")
@@ -179,7 +179,7 @@ func TestLoadAndParseDefaultLimits(t *testing.T) {
 	// Burst cannot be 0.
 	_, err = loadAndParseDefaultLimits("testdata/busted_default_burst_0.yml")
 	test.AssertError(t, err, "single default limit with burst=0")
-	test.Assert(t, !os.IsNotExist(err), "test file should exist")
+	test.AssertContains(t, err.Error(), "invalid burst")
 
 	// Name cannot be empty.
 	_, err = loadAndParseDefaultLimits("testdata/busted_default_empty_name.yml")

diff --git a/ratelimits/names.go b/ratelimits/names.go
@@ -251,7 +251,7 @@ var stringToName = func() map[string]Name {
 
 // limitNames is a slice of all rate limit names.
 var limitNames = func() []string {
-	names := make([]string, len(nameToString))
+	names := make([]string, 0, len(nameToString))
 	for _, v := range nameToString {
 		names = append(names, v)
 	}