Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth2Request should access grant_type through data #651

Closed
wants to merge 1 commit into from

Conversation

apvd
Copy link

@apvd apvd commented May 30, 2024

The grant_type property of the OAuth2Request class should refer to the data collection (consistent with the other properties response_type, client_id, etc. and not through the base form. Without this change the following grant setting will not function:

TOKEN_ENDPOINT_HTTP_METHODS = ["GET"]

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

  • You consent that the copyright of your pull request source code belongs to Authlib's author.

@codespearhead
Copy link

codespearhead commented Jul 4, 2024

I'd argue that's by design, as stated here: #658 .

@apvd
Copy link
Author

apvd commented Jul 11, 2024

RFC frowns upon GET requests for token endpoint.
https://datatracker.ietf.org/doc/html/rfc6749#section-3.2

@apvd apvd closed this Jul 11, 2024
@apvd apvd deleted the apvd/django_request branch July 11, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants