Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fileserv::get_static_file for tower_http ^0.4 #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update fileserv::get_static_file for tower_http ^0.4 #47

wants to merge 1 commit into from

Conversation

mondeja
Copy link
Contributor

@mondeja mondeja commented Aug 16, 2024 •
edited
Loading

See v0.4.0 release of tower_http:

ServeDir and ServeFile's error types are now Infallible and any IO errors will be converted into responses.

I'm getting an unreachable pattern clippy warning for Err because of this.

@mondeja mondeja changed the title Update fileserv::get_static_file for tower_http >= v0.4 Update fileserv::get_static_file for tower_http ^0.4 Aug 16, 2024
@mondeja mondeja mentioned this pull request Aug 16, 2024
Merged
@NicTanghe NicTanghe mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mondeja