Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the Framework Initial Project Interface #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VitorCarvalho67
Copy link

Framework Interface and Assets Updates

Description

This PR introduces significant improvements to the user interface of the framework, with updates to the app.rs and main.scss files. Additionally, a new image has been added to the assets to enhance the visual interface of the project.

Changes

  • User Interface (UI) Improvements:

    • app.rs: Updates to the rendering logic to enhance the user experience.
    • main.scss: Adjustments to the styles to improve the visual appearance of the standard interface.
  • Asset Addition:

    • A new image has been added to the assets directory, aiming to improve the aesthetics and visual appeal of the framework.

Reason

The changes were made to enhance the user experience, modernize the framework's interface, and make it more attractive and intuitive for developers and end-users.

Impact

These updates are expected to improve user satisfaction with the framework, increase ease of use, and promote a more enjoyable interaction with the project's interface.

Screenshot

Screenshot_294

@gbj
Copy link
Contributor

gbj commented Mar 22, 2024

Thanks for your contribution. From my perspective:

Pros

  • Looks cooler when someone starts their first new project

Cons

  • Adds a bunch of stuff that needs to be deleted from every project

For me, the negative outweighs the positive here. But I can understand the appeal and am open to being wrong.

@VitorCarvalho67
Copy link
Author

Thank you for responding, and I'm glad you consider it a positive point for those starting their first project. However, I somewhat disagree with what you call a con. For example, JavaScript frameworks often contain much more code that needs to be deleted to start a clean project, especially when using Vite.
Moreover, it can make the framework more appealing to new developers, since for many, a Rust framework for the client side is something unfamiliar. Frontend frameworks are based on attractiveness not only by their potential but also by their convenience and appearance. I think this commit could bring that to the project.

@alex-uniko
Copy link

Hey, you're both spot on! Just to add a bit of context from a Leptos newbie's perspective—I'm all in on this framework from now on.

Things are pretty clear now, but I still think these kinds of improvements should be on the main website and in the examples.

To attract developers who use Vite, Vue, or other frameworks, I think the official page and community events need to be stronger. The RustNation UK presentation showed Leptos' potential, but it might not be that appealing to people who don't know Rust and just want a pretty site without much effort (which is what a lot of frameworks with complex templates do, and you end up not using half of it).

So, I'd say keep the templates as bare-bones as possible. The less you have to delete, the better the developer experience—I'm definitely speaking from personal experience here!

Maybe as a template improvement, you could add options for including Tailwind CSS or Bulma with something like --style tailwind (but that's a whole other topic) XD

Regards and super awesome work @gbj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants