Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl IntoStyle for Option<impl IntoStyle & Oco #3119

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

zakstucke
Copy link
Contributor

No description provided.

tachys/src/html/style.rs Outdated Show resolved Hide resolved
@gbj
Copy link
Collaborator

gbj commented Oct 22, 2024

Thanks so much for your work on this. Adding a reset is a clever way of doing this and definitely the right approach. (The same thing probably needs to happen for classes but I will take a look at that separately)

I left just two small comments, and then I think this is ready to go.

@zakstucke
Copy link
Contributor Author

Should be fixed. Yeah this'll apply to the IntoClass too which will suffer from the same issue currently.

@gbj
Copy link
Collaborator

gbj commented Oct 25, 2024

Thanks very much for all your work!

@gbj gbj merged commit a437289 into leptos-rs:main Oct 25, 2024
73 checks passed
@zakstucke
Copy link
Contributor Author

zakstucke commented Oct 25, 2024

@gbj thanks! Just fyi, we're still missing the optional variant of impl<F, S> IntoStyle for (&'static str, F) for the style:foo=Option<T> case, it seems those might have to be manual impls, but a bit annoying the duplication, so I wasn't sure. Probably the same for IntoClass too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants