Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression tests for double suspense/double resource fetch #3103

Merged
merged 9 commits into from
Oct 25, 2024
Merged

Regression tests for double suspense/double resource fetch #3103

merged 9 commits into from
Oct 25, 2024

Commits on Oct 25, 2024

  1. test: first cut of the instrumented suspense_tests 

    - Based on initial concepts developed for reproducing leptos-rs#2937 and others,
  streamlined and instrumented for e2e testing and refined for inclusion
  as a standalone module to be plugged into some other App.
    @metatoaster
    metatoaster committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f16d729 View commit details
    Browse the repository at this point in the history

  2. First cut of the fixtures and tests

    @metatoaster
    metatoaster committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5274c39 View commit details
    Browse the repository at this point in the history

  3. Actually make it work properly 

    - Instead of using examples, just feed it the table because examples
  will rerun the whole scenario from scratch, which isn't what we are
  trying to test here.
- Provide a basic example with item listing to show how this will work.
    @metatoaster
    metatoaster committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    fe83d4e View commit details
    Browse the repository at this point in the history

  4. Use ticketing system to disambiguate CSR calls 

    - Keep all SSR calls on ticket 0 as a means to disambiguate them from
  CSR calls.  For the mean time the focus of tests isn't on that
  behavior but this may be modified when suitable.
    @metatoaster
    metatoaster committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    df0c620 View commit details
    Browse the repository at this point in the history

  5. Update the baseline fixtures 

    - Given the new understanding, the scenerios all being the baseline
  tests they are now moved into one file.
- Have the checks against all calls at once for better diff output,
  and reword the new scenerios into more idomatic gherkin.
- Streamline the steps and provide additional ones that will help with
  feature definitions.
    @metatoaster
    metatoaster committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    071ff01 View commit details
    Browse the repository at this point in the history

  6. Translate the reproduction steps into Gherkin

    @metatoaster
    metatoaster committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    558e507 View commit details
    Browse the repository at this point in the history

  7. Comment out logging to avoid output interference.

    @metatoaster
    metatoaster committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    7c6f1d5 View commit details
    Browse the repository at this point in the history

  8. Be able to reset CSR counters everywhere 

    - Done by providing a button directly on the top level component with
  the navigation footer.  This will be useful for the next test.
    @metatoaster
    metatoaster committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    777932d View commit details
    Browse the repository at this point in the history

  9. Test showing difference between hydrate and CSR 

    - Specifically, under hydrated load, resources that shouldn't need
  refetching gets refetched, while CSR does not show this issue.
    @metatoaster
    metatoaster committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d3c3b22 View commit details
    Browse the repository at this point in the history