Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): scan panic error, docker-container error handling by converting state.error to string #4

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix(components): scan panic error, docker-container error handling by converting state.error to string #4

merged 1 commit into from
Aug 19, 2024

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Aug 17, 2024 •
edited
Loading

Before:

Cannot handle error like

{"level":"debug","ts":"2024-08-17T01:53:44Z","caller":"query/poller.go:134","msg":"polling error","id":"docker-container","error":"Error response from daemon: client version 1.44 is too new. Maximum supported API version is 1.43"}

Screenshot 2024-08-17 at 10 04 37 AM Screenshot 2024-08-17 at 10 02 07 AM

After:

Screenshot 2024-08-17 at 10 04 51 AM

@gyuho gyuho self-assigned this Aug 17, 2024
@gyuho
fix(components): scan panic error, docker-container error handling by…
15e303d 
… converting state.error to string

Signed-off-by: Gyuho Lee <[email protected]>
hm2501
hm2501 approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@hm2501 hm2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gyuho gyuho merged commit 07a0596 into main Aug 19, 2024
5 checks passed
@gyuho gyuho deleted the fix-various-bugs branch August 19, 2024 08:06
@gyuho gyuho mentioned this pull request Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hm2501 hm2501 hm2501 approved these changes

Assignees

@gyuho gyuho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gyuho @hm2501