feat: Add TimeBoundedPopScore for time-bounded popularity #493
+120
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZiyaoWei
commented
Oct 18, 2024
| def fit(self, data: Dataset, **kwargs): | ||
| _logger.info("counting time-bounded item popularity") | ||
|
|
||
| log = data.interaction_log("numpy") |
There was a problem hiding this comment.
I was thinking about adding a function to time bound a DataSet, but realized that might be too much since we are just going to use the counts - I assume that would still be useful for some things (validation set?) but doing the calculation here seems cheaper. LMK if this seems right!
| def test_time_bounded_pop_score_rank(): | ||
| algo = basic.TimeBoundedPopScore(2 * day, "rank") | ||
| algo.fit(simple_ds) | ||
| assert algo.item_scores_.equals(pd.Series([1.5, 3.0, 1.5], index=[1, 2, 3])) |
There was a problem hiding this comment.
These tests here seems very low level but I think it is OK since the internals are important and are likely to be stable over time?
|
The LensKit 🤖 has run the tests on your PR. ✅ Tests covered 95.83% of diff. ✅ Coverage increased 0.01% from 92.47% to 92.48%. origin/main...HEAD, staged and unstaged changes
Summary
Source Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #359.