-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize full pipeline configurations #469
Serialize full pipeline configurations #469
Conversation
@@ -139,7 +143,7 @@ def create_input(self, name: str, *types: type[T] | None) -> Node[T]: | |||
""" | |||
self._check_available_name(name) | |||
|
|||
node = InputNode[Any](name, types=set((t if t is not None else type[None]) for t in types)) | |||
node = InputNode[Any](name, types=set((t if t is not None else type(None)) for t in types)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bugfix for existing code around None
.
The GitHub 🤖 has run the tests on your PR. Covered 96.00% of diff (coverage changed 0.10% from 92.05% to 92.15%). origin/main...HEAD, staged and unstaged changes
Summary
Source Coverage Report
|
The GitHub 🤖 has run the tests on your PR. Covered 93.65% of diff (coverage changed 0.05% from 92.05% to 92.11%). origin/main...HEAD, staged and unstaged changes
Summary
Source Coverage Report
|
The GitHub 🤖 has run the tests on your PR. Covered 94.84% of diff (coverage changed 0.10% from 92.05% to 92.16%). origin/main...HEAD, staged and unstaged changes
Summary
Source Coverage Report
|
The GitHub 🤖 has run the tests on your PR. Covered 94.08% of diff (coverage changed 0.07% from 92.05% to 92.13%). origin/main...HEAD, staged and unstaged changes
Summary
Source Coverage Report
|
This extends the configuration support to enable entire pipeline configurations to be serialized and deserialized. It is also a prerequisite for implementing #385. This version of the changes only generates the serialization — it does not save or load them to files, that will be a separate change.
It also renames and refactors some pipeline test files for clarity and improves error handling.
Working: