Serialize full pipeline configurations #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdekstrand
commented
Aug 7, 2024
| @@ -139,7 +143,7 @@ def create_input(self, name: str, *types: type[T] | None) -> Node[T]: | |||
| """ | |||
| self._check_available_name(name) | |||
|
|
|||
| node = InputNode[Any](name, types=set((t if t is not None else type[None]) for t in types)) | |||
| node = InputNode[Any](name, types=set((t if t is not None else type(None)) for t in types)) | |||
There was a problem hiding this comment.
Bugfix for existing code around None.
|
The GitHub 🤖 has run the tests on your PR. Covered 96.00% of diff (coverage changed 0.10% from 92.05% to 92.15%). origin/main...HEAD, staged and unstaged changes
Summary
Source Coverage Report
|
|
The GitHub 🤖 has run the tests on your PR. Covered 93.65% of diff (coverage changed 0.05% from 92.05% to 92.11%). origin/main...HEAD, staged and unstaged changes
Summary
Source Coverage Report
|
|
The GitHub 🤖 has run the tests on your PR. Covered 94.84% of diff (coverage changed 0.10% from 92.05% to 92.16%). origin/main...HEAD, staged and unstaged changes
Summary
Source Coverage Report
|
|
The GitHub 🤖 has run the tests on your PR. Covered 94.08% of diff (coverage changed 0.07% from 92.05% to 92.13%). origin/main...HEAD, staged and unstaged changes
Summary
Source Coverage Report
|
mdekstrand
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the configuration support to enable entire pipeline configurations to be serialized and deserialized. It is also a prerequisite for implementing #385. This version of the changes only generates the serialization — it does not save or load them to files, that will be a separate change.
It also renames and refactors some pipeline test files for clarity and improves error handling.
Working: