Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to setup a custom truststore for the JVM #25

Merged
merged 2 commits into from
Feb 23, 2020
Merged

Add support to setup a custom truststore for the JVM #25

merged 2 commits into from
Feb 23, 2020

Conversation

johnathana
Copy link
Contributor

Introducing to new environmental variables:

  • FILECONTENT_JVM_SSL_TRUSTSTORE: the contents of truststore file (binary or base64 encoded)
  • FILECONTENT_JVM_SSL_TRUSTSTORE_PASSWORD: the truststore password

Add support to setup a custom truststore for the JVM.
b1d5e63 
Introducing to new environmental variables:
* FILECONTENT_JVM_SSL_TRUSTSTORE: the contents of truststore file (binary or base64 encoded)
* FILECONTENT_JVM_SSL_TRUSTSTORE_PASSWORD: the truststore password
@andmarios
Copy link
Contributor

This is blocked by issue #26

andmarios
andmarios approved these changes Feb 23, 2020
View reviewed changes
Copy link
Contributor

@andmarios andmarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this it is important to also fix #26 because unlike other truststores that we may load into specific parts of Lenses, this one is the generic one and more probably to be larger (include many CAs).

@andmarios andmarios merged commit 8b492b5 into master Feb 23, 2020
@andmarios
Copy link
Contributor

Thank you!

@andmarios andmarios deleted the jvm-trust-store branch February 23, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andmarios andmarios andmarios approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnathana @andmarios