fix(accountapp): add missing default image.pullPolicy and unit tests (

jenkins-infra#593)

* fix(accountapp): add missing default `image.pullPolicy` and unit tests

* bump chart version

.github/workflows/test.yml

@@ -11,6 +11,7 @@ jobs:
     strategy:
       matrix:
         chart:
+          - accountapp
           - artifact-caching-proxy
           - httpredirector
           - jenkins-jobs

charts/accountapp/Chart.yaml

@@ -3,4 +3,4 @@ description: A Helm chart for accounts.jenkins.io
 maintainers:
 - name: timja
 name: accountapp
-version: 0.5.26
+version: 0.6.0

charts/accountapp/tests/defaults_test.yaml

@@ -0,0 +1,24 @@
+suite: default tests
+values:
+  - ../values.yaml
+  - secrets_default_values.yaml
+templates:
+  - deployment.yaml
+  - ingress.yaml
+  - secret.yaml # Direct dependency of deployment.yaml
+tests:
+  - it: should create an ingress by default
+    template: ingress.yaml
+    asserts:
+      - hasDocuments:
+          count: 1
+  - it: should define the default deployment with default imagePullPolicy
+    template: deployment.yaml
+    asserts:
+      - hasDocuments:
+          count: 1
+      - isKind:
+          of: Deployment
+      - equal:
+          path: spec.template.spec.containers[0].imagePullPolicy
+          value: IfNotPresent

charts/accountapp/tests/secrets_default_values.yaml

@@ -0,0 +1,6 @@
+ldap:
+  password: ldap-password
+jira:
+  password: jira-password
+smtp:
+  password: smtp-password

charts/accountapp/values.yaml

@@ -5,6 +5,7 @@ replicaCount: 1
 image:
   repository: jenkinsciinfra/account-app
   tag: 0.4.29
+  pullPolicy: IfNotPresent
 imagePullSecrets: []
 nameOverride: ""
 fullnameOverride: ""