Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply zooming with grouped bars #862

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Apply zooming with grouped bars #862

wants to merge 4 commits into from

Conversation

Fadi-Aldalati
Copy link

  • Resetting data and range when selecting points on x axis gives the same behavior as zooming when having grouped bars

@leeoniya
Copy link
Owner

leeoniya commented Aug 2, 2023

hey, thanks for the PR.

it's kind of impossible to review this with all the unrelated formatting changes. would you mind reducing this to only the necessary changes?

@Fadi-Aldalati
Copy link
Author

Actually the changes are not that many do you want me to tell which are the changed lines in the code?

@Fadi-Aldalati
Copy link
Author

You're welcome and I hope the PR will be helpful

@Fadi-Aldalati
Copy link
Author

I removed all formatter changes I hope it's easier to review now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fadi-Aldalati @leeoniya