Version bump #162
Open
Version bump #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rework this to have a single variable controlling the version everywhere |
AtibQur
requested review from
alexp-sssup
and removed request for
alexp-sssup
alexp-sssup
requested changes
Nov 7, 2024
| ``` | ||
| <div style={{ textAlign: "center", margin: "0 auto", color: "#ff6347" }}> | ||
| <script src=`https://cxrtnc.leaningtech.com/`{VERSION} | ||
| `/cx.js`></script> |
There was a problem hiding this comment.
This is the end result, and it's quite poor
Try to get a better understanding about how the code formatting library works, there must be a way to tell the system to apply the same formatting used for ``` blocks to arbitrary blocks of HTML code
| @@ -23,12 +28,13 @@ CheerpX is also available as an ES6 JavaScript module. If you prefer to use the | |||
|
|
|||
| ```html | |||
| <script type="module"> | |||
| import * as CheerpX from "https://cxrtnc.leaningtech.com/1.0.0/cx.esm.js"; | |||
| // Insert the version number of CheerpX | |||
| import * as CheerpX from "https://cxrtnc.leaningtech.com/{VERSION_NUMBER}/cx.esm.js"; | |||
There was a problem hiding this comment.
This does not work, as expected
Please use a local build, it does not make sense for me to review a not yet working solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.