Record metrics #17
Merged
Record metrics #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a couple metrics that try to mirror the ones from python, many of the python ones don't apply, and vice-versa.
lyoshenka
approved these changes
Oct 18, 2021
| @@ -44,7 +46,7 @@ type record struct { | |||
| RepostCount uint32 `json:"repost_count"` | |||
| EffectiveAmount uint64 `json:"effective_amount"` | |||
| SupportAmount uint64 `json:"support_amount"` | |||
| TrendingScore float64 `json:"TrendingScore"` | |||
| TrendingScore float64 `json:"trending_score"` | |||
server/search.go
Outdated
| // TODO record metric search_counter | ||
| t0 := time.Now() | ||
| metrics.RequestsCount.With(prometheus.Labels{"method": "search"}).Inc() | ||
| metrics.SessionCount.Inc() |
There was a problem hiding this comment.
does calling Search really start a new session? seems like that should go somewhere else
There was a problem hiding this comment.
Perhaps this is a misnomer, I wanted to replicate this metric https://github.com/lbryio/lbry-sdk/blob/master/lbry/wallet/server/session.py#L140 I figured that since each search is a grpc call that it would constitute a client "session" connected to the hub.
Consolidated error metrics into a vector counter with a label, removed other uneeded counters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple metrics that try to mirror the ones from python,
many of the python ones don't apply, and vice-versa.
closes #8