fix: Allow event retries even if initial request fails to connect #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
commented
Jul 30, 2024
| @@ -107,8 +107,8 @@ where | |||
| } | |||
| }; | |||
|
|
|||
| for attempt in 0..2 { | |||
| if attempt == 1 { | |||
| for attempt in 1..=2 { | |||
There was a problem hiding this comment.
I feel like it makes more sense to be 1-based in this situation, even though I typically prefer 0 based loops.
| @@ -134,6 +134,7 @@ where | |||
|
|
|||
| let response = match result { | |||
| Ok(response) => response, | |||
| Err(_) if attempt == 1 => continue, | |||
There was a problem hiding this comment.
A customer opened an issue because their logs are filled with the message show in the other error branch. While this change doesn't necessarily fix their specific problem, it should help in a couple of ways.
- Originally, we were considering the original failure to be unrecoverable, which might not be true. So more events might start making it through.
- We won't log anything on the first failure, so if the failure is temporary, we won't unnecessarily alert customers.
kinyoklion
approved these changes
Jul 30, 2024
keelerm84
pushed a commit
that referenced
this pull request
Aug 8, 2024
🤖 I have created a release *beep* *boop* --- ## [2.2.1](2.2.0...2.2.1) (2024-08-08) ### Bug Fixes * Allow event retries even if initial request fails to connect ([#93](#93)) ([a9c0150](a9c0150)) * Suppress error log on `es::Error::Eof` ([#96](#96)) ([20d0891](20d0891)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.