fix: Fix evaluation race between status and flag fields #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the SDK is first initializing, the flag field is set before the status field on the LaunchDarkly node. As a result, listeners on the flag field would be executed before the status field is changed. If a flag change listener tries to evaluate a flag the first time a change is triggered, the default value will be returned along with an error that the client isn't ready since the SDK doesn't think it is initialized. To fix this, evaluation is allowed to continue if the SDK is initialized or if the store has flag data present. This is inline with other mobile SDKs.
kinyoklion
reviewed
Apr 9, 2024
| }, | ||
|
|
||
| initialized: function() as Boolean |
There was a problem hiding this comment.
Both implementations being in the same file makes this so confusing.
kinyoklion
approved these changes
Apr 9, 2024
keelerm84
pushed a commit
that referenced
this pull request
Apr 10, 2024
🤖 I have created a release *beep* *boop* --- ## [2.1.1](2.1.0...2.1.1) (2024-04-10) ### Bug Fixes * Fix evaluation race between status and flag fields ([#29](#29)) ([2677895](2677895)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the SDK is first initializing, the flag field is set before the status field on the LaunchDarkly node. As a result, listeners on the flag field would be executed before the status field is changed.
If a flag change listener tries to evaluate a flag the first time a change is triggered, the default value will be returned along with an error that the client isn't ready since the SDK doesn't think it is initialized.
To fix this, evaluation is allowed to continue if the SDK is initialized or if the store has flag data present. This is inline with other mobile SDKs.