-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update README with updated counts #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… semantic difference
Contexts can now be created from the legacy user schema as well as the new single-kind and multi-kind context schemas. Subsequent work will be done to expose more of the context objects internals for evaluation and event handling.
New reference values can be created using the literal or new JSON-pointer-esque syntax. These references can be used to retrieve values from a context through the getValueForReference method.
This commit takes a big leap forward in terms of u2c support by - Switching to v2 of the contract tests - Replacing all user references with context references - Updating event schema and networking endpoints to use u2c alternatives - Skeleton placeholder for context encoding methods There are several new test suppressions, but those will be resolved as we address attribute redaction and the new summary event structure.
Originally the streaming connection always used port 80. The SDK test harness needs to connect on non-standard ports, so I tried to support connecting to any defined port. However, I should have only been setting this port if it was explicitly provided. Otherwise, I should have defaulted to port 80. This commit should remedy that.
Because the Roku cannot natively handle SSE, it must interact with alternative endpoints. These endpoints communicate via custom encryption. Our SDK test harness does not support this encryption. Therefore, to fully integrate with the test harness, we need to introduce a way for the SDK to communicate with the streaming endpoint in plain text mode. This commit introduces a private variable on the config we can toggle to enable this plain text mode, which we do for the contract tests only. A related commit will be introduced into the SDK test harness to provide support for the Roku's alternative endpoints.
This pull request was auto generated by the Launchdarkly Github Standards automation platform. * Add default CODEOWNERS file
louis-launchdarkly
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.