feat(dev-server): Add toast for successful sync and warning for failure #450
Conversation
cdelst
commented
Oct 17, 2024
cdelst
commented
cdelst
changed the title
| @@ -28,6 +29,7 @@ const Root = () => { | |||
| <React.StrictMode> | |||
| <IconProvider> | |||
| <App /> | |||
There was a problem hiding this comment.
Should it be at the top? That's where most of the latent interactions happen.
There was a problem hiding this comment.
TBH, not sure. I think just having it somewhere relatively global is standard.
Don't think it matters that much here?
There was a problem hiding this comment.
oh like at the top of the page. Screenshot makes it look like maybe it's at the bottom of the page?
There was a problem hiding this comment.
Location in the markup seems fine.
There was a problem hiding this comment.
ohhh, yea... bottom of the page is standard for toasts and I don't think We can change that. The ToastProvider doesn't actually control that either. The position is absolute no matter where we render the provider
There was a problem hiding this comment.
When using it it's clear enough to give some confirmation 👍🏻
cdelst
deleted the
cdelst/FUN-195/add-toast-on-successful-sync-and-update
branch
