fix: LaunchDevly: Pagination for 'Only show flags with overrides' #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdelst
commented
Sep 12, 2024
| @@ -231,6 +243,7 @@ function Flags({ | |||
| setSearchTerm(e.target.value); | |||
| setCurrentPage(0); // Reset pagination | |||
| }} | |||
| value={searchTerm} | |||
There was a problem hiding this comment.
Previously the input of the search box wasn't actually coupled to the display of the search... We were just relying on onChange events.
cdelst
commented
Sep 12, 2024
| @@ -247,10 +260,6 @@ function Flags({ | |||
| const hasOverride = flagKey in overrides; | |||
| const currentValue = hasOverride ? overrideValue : flagValue; | |||
|
|
|||
| if (onlyShowOverrides && !hasOverride) { | |||
There was a problem hiding this comment.
This was causing issues, because we need to not do any filter logic in the display logic for the pagination to work as expected.
cdelst
commented
Sep 12, 2024
| return filtered; | ||
| }, [flags, searchTerm]); | ||
| return flagEntries | ||
| .filter((entry) => { |
There was a problem hiding this comment.
Refactored to be clearer filter entries. I assume we'll add another for tags in the future ;)
cdelst
changed the title
cdelst
changed the title
mike-zorn
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the interaction with pagination when toggling the "only" toggle. Puts the filter ahead of the display logic so that our pagination doesn't get confused why the render is leaving flags out.
This works as expected now.