fix: Use correct flag version in evaluation events. #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Oct 7, 2024
| @@ -398,7 +398,7 @@ packages: | |||
| path: "../../packages/flutter_client_sdk" | |||
| relative: true | |||
| source: path | |||
| version: "4.6.0" | |||
| version: "4.7.0" | |||
kinyoklion
commented
Oct 7, 2024
| @@ -551,7 +551,7 @@ final class LDCommonClient { | |||
| ? DateTime.fromMillisecondsSinceEpoch( | |||
| evalResult!.flag!.debugEventsUntilDate!) | |||
| : null, | |||
| version: evalResult?.version)); | |||
| version: evalResult?.flag?.flagVersion ?? evalResult?.version)); | |||
There was a problem hiding this comment.
Primary change of importance.
tanderson-ld
approved these changes
Oct 8, 2024
This was referenced Oct 9, 2024
kinyoklion
pushed a commit
that referenced
this pull request
Oct 9, 2024
🤖 I have created a release *beep* *boop* --- ## [1.2.1](launchdarkly_dart_common-v1.2.0...launchdarkly_dart_common-v1.2.1) (2024-10-09) ### Bug Fixes * Use correct flag version in evaluation events. ([#166](#166)) ([5d3e826](5d3e826)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kinyoklion
added a commit
that referenced
this pull request
Oct 9, 2024
🤖 I have created a release *beep* *boop* --- ## [1.3.1](launchdarkly_common_client-v1.3.0...launchdarkly_common_client-v1.3.1) (2024-10-09) ### Bug Fixes * Use correct flag version in evaluation events. ([#166](#166)) ([5d3e826](5d3e826)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Ryan Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an associated change to the sdk-test harness to ensure we don't encounter this again.