Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading and writing bitpacked activations in C++ kernels. #305

Merged
merged 19 commits into from
Apr 7, 2020

Commits on Mar 25, 2020

  1. Support reading and writing bitpacked activations in C++ kernels.

    This feature is disabled by default and so does not change any
    behaviour for new or existing converted models; enabling this feature
    will require changes to the converter to set the correct op flags.
    
    Currently, binary convolutions expect full precision input, bitpack
    that input, perform the computation, and then write full-precision
    output.
    
    This feature allows a binary convolutions to instead perform
    bitpacking inside the kernel and write (8-bit) bitpacked output, and
    for the subsequent binary convolution to skip the usual initial
    bitpacking step and read the already-bitpacked input directly.
    Doing this significantly reduces the number of reads and writes to
    memory and the the overall memory footprint of the model inference.
    
    Support is added only for the C++ kernels (x86 and Arm32). Support
    for the optimised assembly kernels (Arm64) requires additional
    future work.
    AdamHillier committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    be508bf View commit details
    Browse the repository at this point in the history
  2. Return after error.

    AdamHillier committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    4ba2a3b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7ff1f0b View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2020

  1. Configuration menu
    Copy the full SHA
    2db366f View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2020

  1. Configuration menu
    Copy the full SHA
    04ce741 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a1a07f3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a8d1c1d View commit details
    Browse the repository at this point in the history
  4. Rename T -> SrcScalar.

    AdamHillier committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    21aac16 View commit details
    Browse the repository at this point in the history
  5. Review suggestion.

    AdamHillier committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    51b14d1 View commit details
    Browse the repository at this point in the history
  6. Revert "Review suggestion."

    This reverts commit 51b14d1.
    AdamHillier committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    d475b38 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0f93a10 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. Configuration menu
    Copy the full SHA
    539e5ac View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. Configuration menu
    Copy the full SHA
    af89dc8 View commit details
    Browse the repository at this point in the history
  2. Fix arm32 build

    Tombana committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    cb1574a View commit details
    Browse the repository at this point in the history
  3. Rewrite unittests

    Tombana committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    e37c2da View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9ccc367 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2f45415 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. Apply suggestions from code review

    Co-Authored-By: Adam Hillier <[email protected]>
    Tombana and AdamHillier authored Apr 7, 2020
    Configuration menu
    Copy the full SHA
    872bd6b View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-Authored-By: Adam Hillier <[email protected]>
    Tombana and AdamHillier authored Apr 7, 2020
    Configuration menu
    Copy the full SHA
    6b2aa8e View commit details
    Browse the repository at this point in the history