Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theme functions #47

Open
wants to merge 2 commits into
base: 8.x-1.x
Choose a base branch
from
Open

Fix theme functions #47

wants to merge 2 commits into from

Conversation

kimpepper
Copy link
Collaborator

  • Moves theme functions to twig templates and preprocess hooks
  • Adds twig templates
  • Fixes help page not showing

@Berdir
Copy link
Contributor

Berdir commented Nov 27, 2014

This results in a container was serialized error for me in template_preprocess_token_tree(), looks like you're serializing everything in $variables, is that really necessary?

@Berdir
Copy link
Contributor

Berdir commented Feb 12, 2015

Note that I simply fixed them for now by specifying 'function' in hook_theme(). As commented in https://www.drupal.org/node/1962358, I would recommend to refactor the whole display logic there before trying to make them twig templates, a lot of those will hopefully go away.

@jibran
Copy link
Collaborator

jibran commented Feb 14, 2015

NW as per @Berdir's comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants