[1.x] Enforce snake_case methods for PHPUnit method in Laravel preset
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timacdonald
changed the title
snake_case methods for PHPUnit method in Laravel preset
timacdonald
force-pushed
the
phpunit-casing
branch
from
4fe6a0d
to
c889e46
Compare
crynobone
approved these changes
Oct 9, 2024
timacdonald
force-pushed
the
phpunit-casing
branch
from
c889e46
to
f93d67a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Laravel preset should have an opinion on testsuite method casing.
There is always overhead involved working out what casing the testsuite is using. Often there can be multiple casings within a single testsuite. Even in our own ecosystem's packages, when contributions come from different people, we can see different casings within the one project.
The Laravel framework ships with snake casing, so I am proposing we stick with that and never have to waste brain cycles on this again for PHPUnit based testsuites.