Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a vagrant plugin to update the hosts when booting the VM. #277

Closed
wants to merge 1 commit into from
Closed

Add a vagrant plugin to update the hosts when booting the VM. #277

wants to merge 1 commit into from

Conversation

vtalbot
Copy link

@vtalbot vtalbot commented Oct 29, 2015

By adding the plugin vagrant-hostsupdater, if the user has set a hostname to something like laravel.app, it would be automatically added to the /etc/hosts file.

@andrewhood125
Copy link
Contributor

#91

@taylorotwell
Copy link
Member

Going to hold off on this.

@QWp6t
Copy link
Contributor

QWp6t commented Nov 12, 2015

@taylorotwell This would be a fantastic addition to Homestead. I hope you'll reconsider it.

@jonnywilliamson
Copy link
Contributor

What about me on a windows development machine? Why would you only add a plugin that helps MacOs/unix systems?

@QWp6t
Copy link
Contributor

QWp6t commented Nov 12, 2015

The plugin works on Windows...

@jonnywilliamson
Copy link
Contributor

I would tend not to agree.

agiledivider/vagrant-hostsupdater#40

@QWp6t
Copy link
Contributor

QWp6t commented Nov 15, 2015

Well, you're wrong. It works on Windows. I develop on Windows. I use the plugin, literally every day, on Windows. It works fine.

Here are a few options that you have...

  • Set vagrant.exe to open as administrator.
  • Turn off UAC.
  • Add trustInfo element to vagrant.exe application manifest resource. It looks like this...
<trustInfo xmlns="urn:schemas-microsoft-com:asm.v3"><security>
<requestedPrivileges><requestedExecutionLevel level="requireAdministrator" uiAccess="false"></requestedExecutionLevel></requestedPrivileges>
</security></trustInfo>

Any of these methods will work, and there are other more advanced methods that will work as well.

But this isn't a technical support ticket for little old Johnny Williamson. This is a PR for Homestead. And if the Vagrant plugin in question didn't work on Windows (which it does), I still don't see why a lack of Windows support for an optional plugin would preclude it from being added. Your objection is quite frankly absurd.

@jonnywilliamson
Copy link
Contributor

Hehe. I enjoyed that @QWp6t

So basically what you've said is, it works on windows. IF

  1. You give a relatively random plugin administrator rights on your computer OR
  2. You disable the security layer of the computer OR
  3. You have to manually edit an application manifest resource.

Sounds brilliant. Wait no, the other thing...it sounds like a very un-Laravel like support nightmare.

I think Taylor has the right idea here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants