Fix Model->isRelation
Method to Accurately Identify Relationships
#52520
+24
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue in the isRelation method of the HasAttributes trait, where the method would incorrectly return true for any key that exists as a method on the model. This caused issues when determining whether a given key represents a relation.
Previously, isRelation could mistakenly identify non-relationship methods as relationships, leading to unexpected behavior in Eloquent models. This fix ensures that only methods returning a Relation subclass are treated as relations, improving the reliability and accuracy of relationship handling in Eloquent models.