[FIX] primaryreplica connection init #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was accidentally passing the tests (the configuration was still accepted even though it was just empty and the EM was setup with a non primary read connection but a regular one) which I've also made a fix for to verify the resulting connection is indeed a PrimaryReadReplicaConnection
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## 2.0 #561 +/- ##
============================================
+ Coverage 66.92% 66.99% +0.07%
Complexity 564 564
============================================
Files 83 83
Lines 1808 1809 +1
============================================
+ Hits 1210 1212 +2
+ Misses 598 597 -1
☔ View full report in Codecov by Sentry. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was accidentally passing the tests
(the configuration was still accepted even though it was just empty and the EM was setup with a non primary read connection but a regular one) which I've also made a fix for to verify the resulting connection is indeed a PrimaryReadReplicaConnection
Changes proposed in this pull request: