Merge pull request #635 from TomHAnderson/hotfix/coverage-3

phpcs assets pass 1

tests/Assets/Auth/Passwords/UserMock.php

@@ -23,6 +23,5 @@ public function getEmailForPasswordReset()
      */
     public function sendPasswordResetNotification($token)
     {
-        // TODO: Implement sendPasswordResetNotification() method.
     }
 }

tests/Assets/Extensions/ExtensionMock.php

@@ -12,7 +12,7 @@ class ExtensionMock implements Extension
     public function addSubscribers(EventManager $manager, EntityManagerInterface $em): void
     {
         // Confirm it gets called
-        (new ExtensionManagerTest)->assertTrue(true);
+        (new ExtensionManagerTest())->assertTrue(true);
     }
 
     /**

tests/Assets/FakeEventManager.php

@@ -2,6 +2,8 @@
 
 namespace LaravelDoctrineTest\ORM\Assets;
 
-class FakeEventManager extends \Doctrine\Common\EventManager
+use Doctrine\Common\EventManager;
+
+class FakeEventManager extends EventManager
 {
 }

tests/Assets/FilterStub.php

@@ -2,9 +2,12 @@
 
 namespace LaravelDoctrineTest\ORM\Assets;
 
-class FilterStub extends \Doctrine\ORM\Query\Filter\SQLFilter
+use Doctrine\ORM\Query\Filter\SQLFilter;
+use Doctrine\ORM\Mapping\ClassMetadata;
+
+class FilterStub extends SQLFilter
 {
-    public function addFilterConstraint(\Doctrine\ORM\Mapping\ClassMetadata $targetEntity, string $targetTableAlias): string
+    public function addFilterConstraint(ClassMetadata $targetEntity, string $targetTableAlias): string
     {
         return '';
     }

tests/Assets/Middleware/BindableEntityWithInterface.php

@@ -2,7 +2,9 @@
 
 namespace LaravelDoctrineTest\ORM\Assets\Middleware;
 
-class BindableEntityWithInterface implements \LaravelDoctrine\ORM\Contracts\UrlRoutable
+use LaravelDoctrine\ORM\Contracts\UrlRoutable;
+
+class BindableEntityWithInterface implements UrlRoutable
 {
     public $id;
 

tests/Assets/Notifications/NotificationDatabaseStub.php

@@ -2,10 +2,13 @@
 
 namespace LaravelDoctrineTest\ORM\Assets\Notifications;
 
-class NotificationDatabaseStub extends \Illuminate\Notifications\Notification
+use Illuminate\Notifications\Notification as IlluminateNotification;
+use LaravelDoctrine\ORM\Notifications\Notification;
+
+class NotificationDatabaseStub extends IlluminateNotification
 {
     public function toDatabase()
     {
-        return (new \LaravelDoctrine\ORM\Notifications\Notification());
+        return new Notification();
     }
 }

tests/Assets/Notifications/NotificationInvalidStub.php

@@ -2,6 +2,8 @@
 
 namespace LaravelDoctrineTest\ORM\Assets\Notifications;
 
-class NotificationInvalidStub extends \Illuminate\Notifications\Notification
+use Illuminate\Notifications\Notification as IlluminateNotification;
+
+class NotificationInvalidStub extends IlluminateNotification
 {
 }

tests/Assets/Notifications/NotificationStub.php

@@ -2,10 +2,13 @@
 
 namespace LaravelDoctrineTest\ORM\Assets\Notifications;
 
-class NotificationStub extends \Illuminate\Notifications\Notification
+use Illuminate\Notifications\Notification as IlluminateNotification;
+use LaravelDoctrine\ORM\Notifications\Notification;
+
+class NotificationStub extends IlluminateNotification
 {
     public function toEntity()
     {
-        return (new \LaravelDoctrine\ORM\Notifications\Notification());
+        return new Notification();
     }
 }

tests/Assets/Testing/AncestorHydrateableClass.php

@@ -4,9 +4,9 @@
 
 class AncestorHydrateableClass
 {
-    private $name;
+    private string $name = '';
 
-    public function getName()
+    public function getName(): string
     {
         return $this->name;
     }

tests/Assets/Testing/ChildHydrateableClass.php

@@ -4,9 +4,9 @@
 
 class ChildHydrateableClass extends AncestorHydrateableClass
 {
-    private $description;
+    private string $description = '';
 
-    public function getDescription()
+    public function getDescription(): string
     {
         return $this->description;
     }

tests/TestCase.php

@@ -12,10 +12,19 @@ class TestCase extends PHPUnitTestCase
     protected function setUp(): void
     {
         $this->application = new Application();
+
+        parent::setUp();
     }
 
     protected function tearDown(): void
     {
         unset($this->application);
+
+        parent::tearDown();
+    }
+
+    public function getApplication(): Application
+    {
+        return $this->application;
     }
 }