Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narek/bm25 bloom #343

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Narek/bm25 bloom #343

wants to merge 16 commits into from

Conversation

Ngalstyan4
Copy link
Contributor

No description provided.

@Ngalstyan4 Ngalstyan4 requested a review from var77 October 15, 2024 02:52
greptile-apps[bot]
greptile-apps bot reviewed Oct 15, 2024
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/usage

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

dqii
dqii reviewed Oct 15, 2024
View reviewed changes
lantern_extras/src/lib.rs Outdated Show resolved Hide resolved
@Ngalstyan4
Rename cargo to cargo.toml in .cargo
fc9df71 
.cargo/config has been deprecated in favor of config.toml since rust
1.38.
We use Rust 2021 edition, which is stable since 1.56, so it should be
fine to rename the file and avoid the warning during compilation
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

Benchmarks

metric old new pct change
recall (after create) 0.950 0.951 +0.11%
recall (after insert) 0.000 0.000 -
select tps 26607.539 24962.297 -6.18%
select bulk(100) tps 35.451 36.322 +2.46%
select latency (ms) 0.722 ± 1.642𝜎 0.730 ± 1.642𝜎 +1.11%
select bulk(100) latency (ms) 874.591 ± 110.647𝜎 867.111 ± 111.072𝜎 -0.86%
create latency (ms) 393139.712 398001.483 +1.24%
insert tps 471.130 482.135 +2.34%
insert bulk(100) tps 5.017 5.095 +1.55%
insert latency (ms) 67.257 ± 14.674𝜎 65.769 ± 14.568𝜎 -2.21%
insert bulk(100) latency (ms) 6230.209 ± 137.708𝜎 6168.456 ± 111.397𝜎 -0.99%
disk usage (bytes) 8192008192.000 8192008192.000 -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dqii dqii dqii left review comments

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@var77 var77 Awaiting requested review from var77

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ngalstyan4 @CLAassistant @dqii