Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformant span #60

Merged
merged 13 commits into from
Oct 16, 2024
Merged

Conformant span #60

merged 13 commits into from
Oct 16, 2024

Conversation

mauneyc-LANL
Copy link
Collaborator

@mauneyc-LANL mauneyc-LANL commented Oct 8, 2024

PR Summary

A span implementation that (in broad terms) follows C++20. See https://en.cppreference.com/w/cpp/container/span for more information on this.

This replaces the PR provided by @BrendanKKrueger (#47) in giving a more complete span.

@jonahm-LANL @dholladay00

TODO:

  • Implement Testing
  • Cleaner comments

PR Checklist

  • Any changes to code are appropriately documented.
  • Code is formatted.
  • Install test passes.
  • Docs build.
  • If preparing for a new release, update the version in cmake.

@mauneyc-LANL mauneyc-LANL mentioned this pull request Oct 8, 2024
5 tasks
@mauneyc-LANL
Copy link
Collaborator Author

Basically done. Let me know if you want something more or changed. @Yurlungur @dholladay00 @BrendanKKrueger

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mauneyc-LANL this looks really good! Some minor questions with two moderate asks:

  1. Can you add a comment in the docs that we have this backport?
  2. Can you add some tests that show it compiles/runs on device with Kokkos?

ports-of-call/span.hpp Show resolved Hide resolved
ports-of-call/span.hpp Show resolved Hide resolved
ports-of-call/span.hpp Show resolved Hide resolved
ports-of-call/span.hpp Show resolved Hide resolved
test/test_span.cpp Outdated Show resolved Hide resolved
@Yurlungur
Copy link
Collaborator

Looks like last thing is just a sentence in the docs saying this exists. THen I'm happy to merge. 👍

Christopher Mauney added 2 commits October 14, 2024 17:35
@Yurlungur
Copy link
Collaborator

Looks like there's a merge conflict. Other than that, looks good to me

@Yurlungur Yurlungur merged commit 0e9b649 into main Oct 16, 2024
4 checks passed
@Yurlungur Yurlungur deleted the mauneyc/new/span_v1 branch October 16, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants