IM1 WIP - ALT and excess_ice changes #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds another variable of maxalt_ever and its index following existing logic for calculating the maximum active layer thickness (really thaw depth as calculated) to date in the simulation.
Changes needed to get altmax_ever values to initialize correctly. Fixes an issue where altmax_ever would be >30 meters regardless of location/climate due to carrying forward the initial conditions. Now includes a spinup_state flag so that it is set as 0 during spinup, and then increases based on thaw depths over non-spinup cases.
Adds excess ground ice to the col_ws / column water state data structure as a varaible needed for NGEE-Arctic Phase 3 IM1 (improved inundation fraction). Not yet connected to any of the new polygonal ground subtypes of the vegetated columns.
Excess ground ice had been templated in these changes as mass/area - changing to a volume/volume basis (and therefore, now unitless).
Changes dimension on excess_ice parameter in water state types from being one value per column to having dimensions (columns, depth in soil)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges the additions of maximum ALT and excess_ice variables into institutional IM1 (NGEE Arctic permafrost inundation dynamics) branch.