extract comment information #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-goulart
reviewed
Aug 24, 2023
Comment on lines
+106
to
+120
| @property | ||
| def author(self): | ||
| return re.search(r'<!-- ([A-Z]{2}).*', self.comment.__str__()).group(1) | ||
|
|
||
| @property | ||
| def date(self): | ||
| return re.search(r'<!-- [A-Z]{2}@(\d{4}-\d{2}-\d{2}) - [A-Z]+: [\s\S\n]*?-->', self.comment.__str__()).group(1) | ||
|
|
||
| @property | ||
| def tag(self): | ||
| return re.search(r'<!-- [A-Z]{2}@\d{4}-\d{2}-\d{2} - ([A-Z]+): [\s\S\n]*?-->', self.comment.__str__()).group(1) | ||
|
|
||
| @property | ||
| def content(self): | ||
| return re.search(r'<!-- [A-Z]{2}@\d{4}-\d{2}-\d{2} - [A-Z]+: ([\s\S\n]*?)-->', self.comment.__str__()).group(1) |
There was a problem hiding this comment.
While this works fine, maybe for the future it might be worth it to use named groups. From Python re docs:
This would allow you to have a single parse_comment() method without the need to do the same regexp matching multiple times against the same string ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes languagetooler-gmbh/languagetool-premium#6216
Closes languagetooler-gmbh/languagetool-premium#6215
Closes languagetooler-gmbh/languagetool-premium#6214