Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

242 wsl filemounts #250

Merged
merged 4 commits into from
Oct 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@ jobs:
- sign-n-deploy
env:
TERM: xterm
PRERELEASE_TAG: edge
strategy:
matrix:
os:
Expand Down Expand Up @@ -219,14 +218,23 @@ jobs:
sync-username: rtfm-47
- name: Publish to npm
run: |
VERSION=$(node -p "require('./package.json').version")
PACKAGE=$(node -p "require('./package.json').name")

if [ "${{ github.event.release.prerelease }}" == "false" ]; then
npm publish --access public --dry-run
npm publish --access public
echo "::notice title=Published ${{ github.ref_name }} to @${{ github.repository }}::This is a stable release published to the default 'latest' npm tag"
npm dist-tag add "$PACKAGE@$VERSION" edge

echo "::notice title=Published $VERSION to $PACKAGE::This is a stable release published to the default 'latest' npm tag"
echo "::notice title=Updated latest tag to $VERSION::The stable tag now points to $VERSION"
echo "::notice title=Updated edge tag to $VERSION::The edge tag now points to $VERSION"
else
npm publish --access public --tag ${{ env.PRERELEASE_TAG }} --dry-run
npm publish --access public --tag ${{ env.PRERELEASE_TAG }}
echo "::notice title=Published ${{ github.ref_name }} to @${{ github.repository }}@${{ env.PRERELEASE_TAG }}::This is a pre-release published to the '${{ env.PRERELEASE_TAG }}' npm tag"
npm publish --access public --tag edge --dry-run
npm publish --access public --tag edge

echo "::notice title=Published $VERSION to $PACKAGE::This is a prerelease published to the default 'edge' npm tag"
echo "::notice title=Updated edge tag to $VERSION::The edge tag now points to $VERSION"
fi
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_DEPLOY_TOKEN }}
Expand Down
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
## {{ UNRELEASED_VERSION }} - [{{ UNRELEASED_DATE }}]({{ UNRELEASED_LINK }})


### Fixes

* Fixed run-from-source `#shebang` to be more universal
* Fixed `flags: 0x5000: no such file or directory: unknown` on WSL when bind mounting certain files the second time [#242](https://github.com/lando/core/issues/242)
* Fixed bug causing https proxy routes to be assigned when they shouldnt be
* Fixed bug causing cache from repopulating old proxy addresses that have been removed [#209](https://github.com/lando/core/issues/209)
* Fixed bug in `v4` auto `entrypoint` and `command` population
* Fixed regression causing empty tooling `options` to throw an error [#240](https://github.com/lando/core/issues/240)
* Improved merging of same-service, same-hostname-pathname `proxy` routes, fixes [#246](https://github.com/lando/core/issues/246)
* Improved `dns` preference of `ipv4first`

## v3.23.0-beta.4 - [October 22, 2024](https://github.com/lando/core/releases/tag/v3.23.0-beta.4)

Expand Down
10 changes: 8 additions & 2 deletions bin/lando
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#!/usr/bin/env node --dns-result-order=ipv4first
#!/usr/bin/env node


/**
* Main CLI entrypoint that wraps @lando/core@3 or @lando/core@4
Expand All @@ -9,7 +10,12 @@

'use strict';

// mods
// set this first for all other downstream concerns
const dns = require('dns');
// Set DNS result order to IPv4 first
dns.setDefaultResultOrder('ipv4first');

// other mods
const fs = require('fs');
const path = require('path');

Expand Down
5 changes: 0 additions & 5 deletions utils/write-file.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
const fs = require('fs');
const get = require('lodash/get');
const path = require('path');
const remove = require('./remove');

// @TODO: maybe extension should be in {options}?
module.exports = (file, data, options = {}) => {
Expand All @@ -13,13 +12,9 @@ module.exports = (file, data, options = {}) => {
const extension = options.extension || path.extname(file);
// linux line endings
const forcePosixLineEndings = options.forcePosixLineEndings ?? false;
// set overwrite if not set
const overwrite = options.overwrite ?? true;

// data is a string and posixOnly then replace
if (typeof data === 'string' && forcePosixLineEndings) data = data.replace(/\r\n/g, '\n');
// if overwrite is on make sure we purge first
if (overwrite) remove(file);

switch (extension) {
case '.yaml':
Expand Down
Loading