feat: support using general compression for numeric array #3020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyue
changed the title
niyue
commented
Oct 18, 2024
| compressed_bit_width as usize, | ||
| data_type.clone(), | ||
| ))); | ||
| } else if let Some(compression) = field_meta.and_then(Self::get_field_compression) { |
There was a problem hiding this comment.
When bitpacking is not applicable, check if field itself specifies some compression
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3020 +/- ##
==========================================
+ Coverage 78.19% 78.24% +0.04%
==========================================
Files 239 239
Lines 76782 76870 +88
Branches 76782 76870 +88
==========================================
+ Hits 60043 60148 +105
+ Misses 13669 13633 -36
- Partials 3070 3089 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address issue #3019.
In this PR, a general compression encoder can now be selected for numeric arrays. I’ve reused the existing
CompressedBufferEncoderstruct from the codebase, which currently does not appear to be in use elsewhere.