Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit ALgorithmIdentifiers of component keys. #76

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

janklaussner
Copy link
Collaborator

No description provided.

@janklaussner
Copy link
Collaborator Author

Question to group: for RSA key AlgIds it is possible to be very specific on its usage. Do we want/need this?

@ounsworth
Copy link
Contributor

ounsworth commented Oct 17, 2024

This does not yet provide an encoding of OAEP parameters. We need to address that before merging.

Update: Just need John to provide a DER encoding of the RSA-OAEP params.

@janklaussner
Copy link
Collaborator Author

@ounsworth , @johngray-dev : added DER encoding and some places where RSA 4096 combo was missing... I assumed that the OAEP params for RSA 4096 are the same as for RSA 2048

@ounsworth
Copy link
Contributor

Thanks Jan! I'm going to merge this now.

@ounsworth
Copy link
Contributor

@janklaussner your DER encoding of the RSA-OAEP AlgID had an extra NULL at the end that John and I couldn't figure out, so I replaced it with a DER encoding produced by our toolkit.

@ounsworth ounsworth merged commit 9a74e4a into main Oct 18, 2024
2 checks passed
@ounsworth ounsworth deleted the 20-add-a-new-section-explicitly-list-spki-algids branch October 18, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new section: explicitly list SPKI AlgIds
2 participants