New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ str support for var_index of AnnDataCurator #2105

Draft

Zethson wants to merge 3 commits into main from feature/str_var_index_support

Member

Zethson commented Oct 23, 2024 •

edited

Loading

Fixes #2091

Adds support for str in var_index. However, this currently assumes that the var_index is Gene. I am not sure whether this is the right way to go about it. Maybe we should actually just not do this.
If we don't do this, I'd add a type check because it's easy to accidentally pass a str and then be confused.

WDYT @sunnyosun ?

Zethson added 3 commits

October 23, 2024 15:14


          🎨 Add support for str for var_index in AnnDataCurator

8fd3206

Signed-off-by: zethson <[email protected]>


          🎨 Add test

4e7372d

Signed-off-by: zethson <[email protected]>


          🎨 Curator moar

ae9d0e8

Signed-off-by: zethson <[email protected]>

Zethson changed the title ~~✨ var index support~~ ✨ str support for var_index of AnnDataCurator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet