Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Python 3.12 support #2092

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

✨ Python 3.12 support #2092

wants to merge 3 commits into from

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Oct 22, 2024

  • Uses 3.12 instead of 3.11 in the CI
  • Specifies 3.12 support in our classifiers
  • Removes support for Python 3.13

Docs don't build with 3.12:

Extension error:
Could not import extension ablog (exception: No module named 'pkg_resources')

See https://github.com/laminlabs/lndocs/issues/105

Signed-off-by: zethson <[email protected]>
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.53%. Comparing base (c41fc2c) to head (b35200e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2092   +/-   ##
=======================================
  Coverage   92.52%   92.53%           
=======================================
  Files          54       54           
  Lines        6435     6429    -6     
=======================================
- Hits         5954     5949    -5     
+ Misses        481      480    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 22, 2024

@github-actions github-actions bot temporarily deployed to pull request October 22, 2024 09:05 Inactive
Signed-off-by: zethson <[email protected]>
@Koncopd
Copy link
Member

Koncopd commented Oct 22, 2024

We should not use only 3.12 in the CI, it should still have 3.9, 3.10 and 3.12 i think.

Signed-off-by: zethson <[email protected]>
@Zethson Zethson marked this pull request as ready for review October 22, 2024 09:22
@Koncopd
Copy link
Member

Koncopd commented Oct 22, 2024

The problem with ablog is due to our pin actually https://github.com/laminlabs/lndocs/blob/d5247a9fc957a9b74091a9e6ed6d79c713bca106/pyproject.toml#L11
pinging @falexwolf
The latest version of ablog doesn't use pkg_resources.

@github-actions github-actions bot temporarily deployed to pull request October 22, 2024 09:32 Inactive
@Zethson
Copy link
Member Author

Zethson commented Oct 22, 2024

We should not use only 3.12 in the CI, it should still have 3.9, 3.10 and 3.12 i think.

I think 3.9 as a lower bound and 3.12 as the upperbound is fine. We can of course have a bigger matrix but I think it's okay. I think that it's very important that we test 3.12 in the CI.

The problem with ablog is due to our pin actually https://github.com/laminlabs/lndocs/blob/d5247a9fc957a9b74091a9e6ed6d79c713bca106/pyproject.toml#L11
pinging @falexwolf
The latest version of ablog doesn't use pkg_resources.

See https://github.com/laminlabs/lndocs/issues/105

@Koncopd
Copy link
Member

Koncopd commented Oct 22, 2024

I think 3.9 as a lower bound and 3.12 as the upperbound is fine.

Agree, you are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants