-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Python 3.12 support #2092
base: main
Are you sure you want to change the base?
✨ Python 3.12 support #2092
Conversation
Signed-off-by: zethson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2092 +/- ##
=======================================
Coverage 92.52% 92.53%
=======================================
Files 54 54
Lines 6435 6429 -6
=======================================
- Hits 5954 5949 -5
+ Misses 481 480 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zethson <[email protected]>
We should not use only 3.12 in the CI, it should still have 3.9, 3.10 and 3.12 i think. |
Signed-off-by: zethson <[email protected]>
The problem with |
I think 3.9 as a lower bound and 3.12 as the upperbound is fine. We can of course have a bigger matrix but I think it's okay. I think that it's very important that we test 3.12 in the CI.
|
Agree, you are right. |
Docs don't build with 3.12:
See https://github.com/laminlabs/lndocs/issues/105