console: fix first input sometimes being lost

CHANGELOG.md

@@ -10,6 +10,7 @@
 - fixed altering fov with `/set` not being immediately respected (#1547)
 - fixed main menu music volume when exiting while underwater with certain music settings (#1540, regression from 4.4)
 - fixed `/kill` command unable to target a special object
+- fixed really fast typing in console sometimes losing the first input (regression from 4.4)
 - improved object name matching in console commands to work like TR2X
 
 ## [4.4](https://github.com/LostArtefacts/TR1X/compare/4.3-102-g458cd96...4.4) - 2024-09-20

src/game/shell.c

@@ -299,12 +299,6 @@ void Shell_ExitSystemFmt(const char *fmt, ...)
 
 void Shell_ProcessInput(void)
 {
-    if (g_InputDB.enter_console) {
-        Console_Open();
-        g_Input.any = 0;
-        g_InputDB.any = 0;
-    }
-
     if (g_InputDB.toggle_bilinear_filter) {
         g_Config.rendering.texture_filter =
             (g_Config.rendering.texture_filter + 1) % GFX_TF_NUMBER_OF;

src/specific/s_shell.c

@@ -219,9 +219,21 @@ void S_Shell_SpinMessageLoop(void)
             }
             break;
 
-        case SDL_KEYDOWN:
-            UI_HandleKeyDown(event.key.keysym.sym);
+        case SDL_KEYDOWN: {
+            // NOTE: This normally would get handled by Input_Update,
+            // but by the time Input_Update gets ran, we may already have lost
+            // some keypresses if the player types really fast, so we need to
+            // react sooner.
+            const INPUT_SCANCODE open_console_scancode =
+                Input_GetAssignedScancode(
+                    g_Config.input.layout, INPUT_ROLE_ENTER_CONSOLE);
+            if (event.key.keysym.scancode == open_console_scancode) {
+                Console_Open();
+            } else {
+                UI_HandleKeyDown(event.key.keysym.sym);
+            }
             break;
+        }
 
         case SDL_TEXTEDITING:
             UI_HandleTextEdit(event.text.text);