Refactoring #1
Open
Refactoring #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract finer grained methods related to continuing capturing answers so that it's more explicit and clear all the steps that are part of the process.
In FormArea, Goals don't require Queue semantics and it's used as a list elsewhere, which required unecessary list allocations to convert from Queue to List.
… A simple foreach will do it
Answers also don't require Queue semantics and they were being converted to string elsewhere anyway. Using a `List<string>` to begin with will avoid extra allocations/conversions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I did some refactoring on your code and tried to provide enough detail on each commit message to give you some context on why I was making those changes.