Forms date formatting #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reference date is MST (seven hours west of GMT). This is a very common mistake when constructing formatting strings to be used with time.Format. Since we converted all dates that includes zone information to UTC *before* outputting in Z time, this bug did not affect the output strings. But it's best to use the correct reference time anyway, in case we later add a string representation including zone information that is not UTC.
xylo04
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered an error in the time formatting strings we use in the forms package, so I wanted to write some tests and fix this.
As it turns out, the error did not affect the outputted strings. It only manifests when outputting datetime strings not in UTC, which none of these does. Anyway, I've added some tests and fixed the layout strings 🙂