Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests and compilation with TAGS=libhamlib #423

Closed
wants to merge 0 commits into from
Closed

fix tests and compilation with TAGS=libhamlib #423

wants to merge 0 commits into from

Conversation

as3ii
Copy link
Contributor

@as3ii as3ii commented Oct 3, 2023 •
edited
Loading

Note: this requires the merge of la5nta/wl2k-go#85

@martinhpedersen martinhpedersen changed the base branch from master to develop October 4, 2023 05:42
@as3ii
Copy link
Contributor Author

as3ii commented Oct 6, 2023 •
edited
Loading

I don't know precisely if this is related to the use of libhamlib, and if this is an issue in pat or in wl2k-go, but sometimes randomly pat starts eating a lot of cpu power. The only way I was able to reproduce consistently this bug was manually disconnecting and reconnecting the usb serial interface to the radio.
This is what perf recorded and found when this happens:
perf

Tell me if I can do anything to help debug this problem

UPDATE: the up-mentioned problem is a hamlib problem, on the pat side it cannot be fixed when using hamlib as a library

martinhpedersen
martinhpedersen reviewed Oct 7, 2023
View reviewed changes
riglist.go Outdated
@@ -10,7 +10,7 @@ package main
import (
"fmt"
"strings"

"context"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we're missing a white space here. Did you go fmt the code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a commit after go fmt. It just reordered the entries

@martinhpedersen
Copy link
Member

I don't know precisely if this is related to the use of libhamlib, and if this is an issue in pat or in wl2k-go, but sometimes randomly pat starts eating a lot of cpu power.

Thanks! I don't think i have seen this when Pat is compiled without TAGS=libhamlib. The feature is rarely used and not enabled in the official releases, so I don't think I'll prioritize debugging this any time soon. Feel free to debug further if you feel like it 🙂

PS: Thanks for the PR! ❤️

martinhpedersen added a commit that referenced this pull request Oct 7, 2023
@martinhpedersen
[email protected] (libhamlib v4.2 compatibility)
8da9a16 
* libhamlib v4.2 compatibility (ref pr #423)
* mailbox: Remove warning on missing file extension
* catalog: Improve position report's Course
@martinhpedersen
Copy link
Member

I've merged the wl2k-go changes and pulled them into Pat's develop branch. Please rebase this PR on top of develop. Thank you 🙂

@martinhpedersen
Copy link
Member

Ooops! I did something wrong while trying to rebase this, and since the PR was automatically closed I no longer have permission to push to your branch.

I'll merge this manually to develop.

Thanks for the PR 😄

@martinhpedersen
Copy link
Member

Merged (b62dbc7).

@martinhpedersen martinhpedersen added this to the v0.15.1 milestone Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinhpedersen martinhpedersen martinhpedersen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.15.1
Development

Successfully merging this pull request may close these issues.
2 participants
@as3ii @martinhpedersen