Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guides): fix connectivity in observability namespace #2088

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Automaat
Copy link
Contributor

We now always add labels with mesh, even if mesh is not specified. Resulting in empty label in policy, for example:

apiVersion: kuma.io/v1alpha1
kind: HostnameGenerator
metadata:
  name: local-mesh-external-service
  namespace: kuma-system
  labels:
    kuma.io/mesh: 

@Automaat Automaat requested a review from a team as a code owner November 14, 2024 17:32
@Automaat Automaat requested review from michaelbeaumont and lobkovilya and removed request for a team November 14, 2024 17:32
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for kuma ready!

Name Link
🔨 Latest commit 1bb68ac
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/6736343e7ca3580008f113ab
😎 Deploy Preview https://deploy-preview-2088--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🟢 up 1 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant