chore: small styles and quality of life improvements #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styles source maps in dev are very helpful during development `css.preprocessorOptions.scss.additionalData` needs to be a string or a function, so having array was wrong and did't work with `devSourcemap` setting. modern scss compiler api is just a suggested by sass and legacy api will be sooner or later removed. Signed-off-by: Bart Smykla <[email protected]>
adding `_assets/styles/` directory to excluded allows vite to handle sass files compilation and when developing won't cause jekyll to hard refresh page whenever styles changes and allow vite to hot reload just styles Signed-off-by: Bart Smykla <[email protected]>
`this.sidebarButton` is null for some pages, like 404 Signed-off-by: Bart Smykla <[email protected]>
1. `vite` is minifying scripts and styles during production builds so it was unnecessary to import minified versions. Importing minified versions was causing that it was harded to debug styles/scripts during developement 2. plugin `prism-show-language` was not used, and it was imported before `prism-toolbar` which was causing it was not even working and logging warninng message in console 3. we are not using `prism-tomorrow` theme 4. moving out copy icon html elements and formated it with new lines made it a little bit easier to read Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
1. `expandActiveGroup` was incorrectly closing groups which were nested more than one level - this commit fixes that 2. smoth scrolling to sidebar element was broken when there was not enough scroll height to show the active link in the middle. In such cases it was moving down global page scroll with the missing height value 3. small refactoring of `setActiveLink` method Signed-off-by: Bart Smykla <[email protected]>
1. now instead of being visible on the left side of the string with a type of code (`yaml`, `sh` etc.) when you are hovering over code block it's hiding the type string and showing always in the same position - top right corner. It was broken before for blocks which types were longer than `sh`. 2. added simple fade for the button on hover 3. fixed position of sting "Copied!" when clicked Signed-off-by: Bart Smykla <[email protected]>
when code block had more than 9 lines it was broken as line numbers 10+ had not enough padding on the left - not it looks fine for line numbers up to 99 Signed-off-by: Bart Smykla <[email protected]>
Now, even if sidebar is longer than the screen height, version selector and search bar will always be present at the top. This commit also removes this weird unnecessary empty space at the bottom of the sidebar. Signed-off-by: Bart Smykla <[email protected]>
1. version alert block now has the same width to the rest of page 2. huge empty space between version alert and the page header was shrinked so it looks more natural Signed-off-by: Bart Smykla <[email protected]>
1. Instead of using raw vite we can use netlify, which we are still using otherwise. It also have result that specified by us redirects in `_common-redirects` and _redirects` files work. 2. Using netlify instead of vite with its scripts under `bin` directory in `Procfile` results in kill signals to properly propagate so `kill-ports` shouldn't be needed 3. I removed unnecessary scripts section from package.json file Signed-off-by: Bart Smykla <[email protected]>
Signed-off-by: Bart Smykla <[email protected]>
bartsmykla
requested review from
slonka and
Automaat
and removed request for
a team
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
There is a lot of frontend stuff here, maybe @johncowen or @schogges can take a look? |
Signed-off-by: Bart Smykla <[email protected]>
johncowen
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sticky version selector and search bar
Fixed / Improved Copy to Clipboard in code blocks
Screen.Recording.2024-11-04.at.11.38.22.mov
Fixed padding in line numbers 10+
Improved version warning block
Fixed issues with scrolling active sidebar link to view, where it was manipulating global scroll, not only sidebar scroll
Improved development workflow in multiple ways
Did you sign your commit? Instructions: 👍
Have you read Contributing guidelines?: 👍