fix(ci): move vale action back to use ubuntu-latest / fix vocab dirs (#…

…1975)

Back in #1972 following a suggested fix for a python error in the  vale GH action, we pinned ubuntu to what seemed like a working version. We've since seen that whilst it looked to be working, there were still errors deeper in the logs that somehow weren't caught by CI.

This PR:

1. Bumps the version of the vale GH action (I'm hoping/assuming this is why these errors weren't caught in CI?)
2. Changes the location of the Base vocabularies as a consequence of the GH action using `latest` for the version of vale to use i.e. vale version 3.something. The previous location was only supported in vale 2.something. This change fixed an error that has been appearing in CI logs over several PRs.
3. Puts things back to use ubuntu latest


Closes: #1973

---------

Signed-off-by: John Cowen <[email protected]>

.github/workflows/ci.yml

@@ -183,9 +183,7 @@ jobs:
 
   vale:
     name: Lint docs
-    # Had to pin to 22.04 because of https://github.com/errata-ai/vale-action/issues/128.
-    # Once fixed upstream we can put it back to latest.
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
     steps:
       - name: Get changed files
         id: changed-files
@@ -206,7 +204,7 @@ jobs:
               .filter(d => !d.filename.includes("/raw/"))
               .map(d => d.filename);
       - uses: actions/checkout@v2
-      - uses: errata-ai/vale-action@v2
+      - uses: errata-ai/vale-action@v2.1.1
         if: join(fromJSON(steps.changed-files.outputs.result)) != ''
         name: Run Vale
         with: