-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script for generating a krew plugin manifest. #645
Add script for generating a krew plugin manifest. #645
Conversation
I've changed it to fetch the archives from Github for hashing. Now you can generate this for any release without needing to build it first.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it looks good :) but please adjust the release documentation - Release.MD to contain information about how to run this and when to run this
The Krew project has not yet defined acceptance criteria for plugins. So I've done some digging to see how we can maximize our chances. Here's an example of a plugin that did poorly in review: kubernetes-sigs/krew-index#146
They also started a document describing criteria that might be helpful: kubernetes-sigs/krew-index#152 In light of this, I think we should spend some time refining the description and short description to be more clear on what KUDO does and why you would install the CLI. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alenkacz, jbarrick-mesosphere, kensipe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
spec: | ||
version: "${VERSION}" | ||
|
||
shortDescription: Declaratively build, install, and run operators using KUDO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattj-io / @yankcrime / @gerred / @runyontr is there someone that would be willing to help me edit the descriptions here?
@jbarrick-mesosphere: GitHub didn't allow me to request PR reviews from the following users: mattj-io. Note that only kudobuilder members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
This adds a script that can generate a krew plugin manifest from the output of goreleaser. I don't know if there's a way to run this with goreleaser, but if there is we should do that.
Which issue(s) this PR fixes:
Fixes #276
Special notes for your reviewer:
Does this PR introduce a user-facing change?: