automation: switch to cargo-llvm-cov #956
Merged
+14
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to cargo-llvm-cov to collect code coverage results. This is required because tarpaulin is consuming too much memory, leading to our GHA being killed. See xd009642/tarpaulin#1639 for more details. Signed-off-by: Flavio Castelli <[email protected]>
flavio
force-pushed
the
switch-to-cargo-llvm-cov
branch
from
f6eb6ea
to
faf5e38
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #956 +/- ##
===========================================
+ Coverage 13.16% 82.98% +69.82%
===========================================
Files 25 25
Lines 2036 4190 +2154
===========================================
+ Hits 268 3477 +3209
+ Misses 1768 713 -1055
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
It works, and what a boost! 🚀 😄 |
|
Some thoughts/highlights:
What do you think? If you agree with that, should we do these changes with another PR? |
viccuad
approved these changes
Oct 23, 2024
|
I've merged it because I'm eager to see the code coverage bump on the main page of codecov 😄 We can keep discussing what to do about the other GHA tasks here or on slack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to cargo-llvm-cov to collect code coverage results. This is required because tarpaulin is consuming too much memory, leading to our GHA being killed.
See xd009642/tarpaulin#1639 for more details.