Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve startup time #954

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: improve startup time #954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions charts/testkube-api/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,14 +223,22 @@ spec:
- name: http
containerPort: 8088
protocol: TCP
livenessProbe:
initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds }}
startupProbe:
initialDelaySeconds: 3
periodSeconds: 3
timeoutSeconds: 3
failureThreshold: 20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess, better to avoid hard coded values

Copy link
Contributor Author

@WitoDelnat WitoDelnat Oct 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, I do not really see use cases where these values should be overridden 🤔 Want to avoid overengineering this and follow YAGNI (You Aren't Gonna Need It)

Let me know if I'm overlooking a valid use case and I'll add it in (now or in a follow up)

httpGet:
path: /health
port: {{ .Values.service.port }}
scheme: HTTP
readinessProbe:
initialDelaySeconds: {{ .Values.readinessProbe.initialDelaySeconds }}
httpGet:
path: /health
port: {{ .Values.service.port }}
scheme: HTTP
livenessProbe:
initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds }}
httpGet:
path: /health
port: {{ .Values.service.port }}
Expand Down
4 changes: 0 additions & 4 deletions charts/testkube-api/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,10 +673,6 @@ testConnection:
livenessProbe:
initialDelaySeconds: 30

## Testkube API Readiness probe
readinessProbe:
initialDelaySeconds: 45

## Testkube API HTTP body size limit
## httpBodyLimit: 1073741824

Expand Down
2 changes: 0 additions & 2 deletions charts/testkube/values-demo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,8 +331,6 @@ testkube-api:
scheme: HTTP
## Amount of request failures before the container receives a terminate signal
failureThreshold: 3
## Time to wait after the initial deployment before performing first probe
initialDelaySeconds: 60
## How often (in seconds) to perform the probes. This value sends one probe every 30 seconds
periodSeconds: 30
## Minimum consecutive successes for the probe to be considered successful after having failed
Expand Down
4 changes: 1 addition & 3 deletions charts/testkube/values-develop.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ testkube-api:
## Amount of request failures before the container receives a terminate signal
failureThreshold: 3
## Time to wait after the initial deployment before performing first probe
initialDelaySeconds: 180
initialDelaySeconds: 60
## How often (in seconds) to perform the probes. This value sends one probe every 30 seconds
periodSeconds: 30
## Minimum consecutive successes for the probe to be considered successful after having failed
Expand All @@ -277,8 +277,6 @@ testkube-api:
scheme: HTTP
## Amount of request failures before the container receives a terminate signal
failureThreshold: 3
## Time to wait after the initial deployment before performing first probe
initialDelaySeconds: 60
## How often (in seconds) to perform the probes. This value sends one probe every 30 seconds
periodSeconds: 30
## Minimum consecutive successes for the probe to be considered successful after having failed
Expand Down
2 changes: 0 additions & 2 deletions charts/testkube/values-stage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,6 @@ testkube-api:
scheme: HTTP
## Amount of request failures before the container receives a terminate signal
failureThreshold: 3
## Time to wait after the initial deployment before performing first probe
initialDelaySeconds: 60
## How often (in seconds) to perform the probes. This value sends one probe every 30 seconds
periodSeconds: 30
## Minimum consecutive successes for the probe to be considered successful after having failed
Expand Down
7 changes: 1 addition & 6 deletions charts/testkube/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,8 +603,7 @@ testkube-api:
- testkube.example.com
tlsenabled: false
# -- Placing a host in the TLS config will indicate a certificate should be created
tls:
[]
tls: []
# - hosts:
# - testkube.example.com
# secretName: testkube-cert-secret
Expand Down Expand Up @@ -750,10 +749,6 @@ testkube-api:
livenessProbe:
# -- Initial delay for liveness probe
initialDelaySeconds: 15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related but this value is different in the umbrella chart 🤔

# -- Testkube API Readiness probe parameters
readinessProbe:
# -- Initial delay for readiness probe
initialDelaySeconds: 30

# -- Enable analytics for Testkube
analyticsEnabled: true
Expand Down