Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for external global template #944

Merged
merged 3 commits into from
Sep 26, 2024
Merged

feat: add support for external global template #944

merged 3 commits into from
Sep 26, 2024

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Sep 26, 2024 •
edited
Loading

Pull request description

global:
  globalTemplate:
    enabled: true
    external: true
    name: my-own-global-template

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Fixes

@rangoo94 rangoo94 requested review from a team as code owners September 26, 2024 13:41
@rangoo94 rangoo94 force-pushed the feat/add-support-for-external-global-template branch from 0e35ff8 to 02bba8f Compare September 26, 2024 13:43
@rangoo94 rangoo94 force-pushed the feat/add-support-for-external-global-template branch from 02bba8f to 96a4178 Compare September 26, 2024 13:45
@ed382 ed382 removed the request for review from a team September 26, 2024 13:47
@rangoo94 rangoo94 merged commit 60d2a73 into main Sep 26, 2024
1 check passed
@rangoo94 rangoo94 deleted the feat/add-support-for-external-global-template branch September 26, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ed382 ed382 ed382 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rangoo94 @ed382