Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indent to 8 for tolerations and nodeSelector #910

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

indent to 8 for tolerations and nodeSelector #910

wants to merge 2 commits into from

Conversation

MartijnDeMoorNN
Copy link

@MartijnDeMoorNN MartijnDeMoorNN commented Jul 12, 2024 •
edited
Loading

The current indentation is set to 6 which places the value on the same level as the tolerations: or the nodeSelector:

Pull request description

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@MartijnDeMoorNN
indent to 8 for tolerations and nodeSelector
2eeb4f2 
The current indentation is set to 6 which places the value on the same level as the tolerations: or the nodeSelector:
@MartijnDeMoorNN MartijnDeMoorNN requested a review from a team as a code owner July 12, 2024 08:55
@MartijnDeMoorNN MartijnDeMoorNN mentioned this pull request Jul 15, 2024
Open
@ypoplavs
Copy link
Contributor

Hello @MartijnDeMoorNN!
Thanks for the PR, however, our release flow expects the changes to be merged to develop first. Could you please re-create your PR to develop instead of main?

@ypoplavs
Copy link
Contributor

Another thing, @MartijnDeMoorNN, we deploy tolerations to our dev clusters and all is working fine, no warnings or whatsoever. Is that breaking smth for you?

@MartijnDeMoorNN
Copy link
Author

Hello @MartijnDeMoorNN! Thanks for the PR, however, our release flow expects the changes to be merged to develop first. Could you please re-create your PR to develop instead of main?

Created a new one:
#917

Another thing, @MartijnDeMoorNN, we deploy tolerations to our dev clusters and all is working fine, no warnings or whatsoever. Is that breaking smth for you?

I noticed that the nodeSelector additions from my values were not correct in the actual deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypoplavs ypoplavs ypoplavs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartijnDeMoorNN @ypoplavs