Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rate limiting per X-Forwarded-For ip #152

Merged
merged 1 commit into from
Sep 27, 2024
Merged

add rate limiting per X-Forwarded-For ip #152

merged 1 commit into from
Sep 27, 2024

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented Sep 19, 2024

No description provided.

Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@matthyx matthyx marked this pull request as ready for review September 23, 2024 08:25
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

slashben
slashben previously approved these changes Sep 24, 2024
Copy link
Contributor

@slashben slashben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but it is not the end of the road.

I think we still need a mechanism that limits the maximum number of parallel requests, regardless to the source IP

@matthyx
Copy link
Contributor Author

matthyx commented Sep 24, 2024

It looks good, but it is not the end of the road.

I think we still need a mechanism that limits the maximum number of parallel requests, regardless to the source IP

I will also make it configurable, and maybe default to no rate limiting

Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@matthyx matthyx merged commit 9018758 into main Sep 27, 2024
6 checks passed
@matthyx matthyx deleted the monaco branch September 27, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants